Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 110373007: Delay loading the NTP after sign in until MergeSession has been performed in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 72a6056990bffcb3c466d42d0a41bc07c8c507cc..eccb3f480430cfb3d823524621ce8a8b8181d9f8 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -449,6 +449,13 @@ void WebstorePrivateBeginInstallWithManifest3Function::SigninSuccess() {
SigninCompletedOrNotNeeded();
}
+void WebstorePrivateBeginInstallWithManifest3Function::MergeSessionComplete(
+ const GoogleServiceAuthError& error) {
+ // TODO(rogerta): once the embeded inline flow is enabled, the code in
+ // WebstorePrivateBeginInstallWithManifest3Function::SigninSuccess()
+ // should move to here.
+}
+
void WebstorePrivateBeginInstallWithManifest3Function::
SigninCompletedOrNotNeeded() {
content::WebContents* web_contents = GetAssociatedWebContents();
@@ -578,7 +585,7 @@ void WebstorePrivateCompleteInstallFunction::OnExtensionInstallSuccess(
if (test_webstore_installer_delegate)
test_webstore_installer_delegate->OnExtensionInstallSuccess(id);
- LOG(INFO) << "Install success, sending response";
+ VLOG(1) << "Install success, sending response";
g_pending_installs.Get().EraseInstall(GetProfile(), id);
SendResponse(true);
@@ -598,7 +605,7 @@ void WebstorePrivateCompleteInstallFunction::OnExtensionInstallFailure(
}
error_ = error;
- LOG(INFO) << "Install failed, sending response";
+ VLOG(1) << "Install failed, sending response";
g_pending_installs.Get().EraseInstall(GetProfile(), id);
SendResponse(false);

Powered by Google App Engine
This is Rietveld 408576698