Issue 110373004: Remove redundant |is_server| argument from TestSession and call the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110373004: Remove redundant |is_server| argument from TestSession and call the (Closed)

Created:
7 years ago by ramant (doing other things)

Modified:
7 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove redundant |is_server| argument from TestSession and call the connection's is_server() method instead. Merge internal change: 58047118 R=rch@chromium.org

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -22 lines)			Patch
M	net/quic/quic_crypto_client_stream_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_crypto_server_stream_test.cc	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages