chrome/browser/sync/profile_sync_service.cc - Issue 11037007: [Sync] Require ProfileSyncService to have an uninitialized backend on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 11037007: [Sync] Require ProfileSyncService to have an uninitialized backend on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index d185511184be7c4e96afc3df20520f73fc1af1ce..95f53af9b1880dcd148eef07a30700ae1a27c2a9 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -166,7 +166,8 @@ ProfileSyncService::ProfileSyncService(ProfileSyncComponentsFactory* factory,

ProfileSyncService::~ProfileSyncService() {

sync_prefs_.RemoveSyncPrefObserver(this);

- Shutdown();

+ // Shutdown() should have been called before destruction.

+ CHECK(!backend_initialized_);

tim (not reviewing) 2012/10/01 21:18:57 Hmm. I think DCHECK is more appropriate here (usin

}

bool ProfileSyncService::IsSyncEnabledAndLoggedIn() {

« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_autofill_unittest.cc » ('j') | no next file with comments »