Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1103603002: Remove deprecated function gcdPrivate.establishSession (Closed)

Created:
5 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated function gcdPrivate.establishSession GCD App already uses gcdPrivate.createSession. BUG=461504 Committed: https://crrev.com/4169d03e08f5257c9a6017bec511399121ac28cd Cr-Commit-Position: refs/heads/master@{#327091}

Patch Set 1 #

Patch Set 2 : Wed Apr 22 16:44:15 PDT 2015 #

Patch Set 3 : Wed Apr 22 17:10:11 PDT 2015 #

Patch Set 4 : Wed Apr 22 22:29:12 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -72 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.h View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 2 chunks +2 lines, -33 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/gcd_private.idl View 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/session.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Vitaly Buka (NO REVIEWS)
5 years, 8 months ago (2015-04-22 23:45:26 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 8 months ago (2015-04-22 23:45:38 UTC) #4
Vitaly Buka (NO REVIEWS)
PTAL
5 years, 8 months ago (2015-04-22 23:45:48 UTC) #5
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-23 19:45:57 UTC) #6
Aleksey Shlyapnikov
lgtm
5 years, 8 months ago (2015-04-23 19:49:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103603002/60001
5 years, 8 months ago (2015-04-27 18:04:48 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 19:00:07 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:00:50 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4169d03e08f5257c9a6017bec511399121ac28cd
Cr-Commit-Position: refs/heads/master@{#327091}

Powered by Google App Engine
This is Rietveld 408576698