Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2027)

Issue 1103533002: [turbofan] remove hint aliasing (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] make register hinting explicit - instead of committing operands early to resolve hints, hold the hint register data on the UsePosition - allow hints to be rolled back efficiently as needed by GreedyAllocator - some small drive by fixes BUG= Committed: https://crrev.com/232b09825c2b1b7c2356f483a1b50c305863ad5f Cr-Commit-Position: refs/heads/master@{#28075}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -213 lines) Patch
M src/compiler/graph-visualizer.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 5 6 7 8 9 10 14 chunks +114 lines, -44 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 5 6 7 8 9 10 35 chunks +362 lines, -159 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
LGTM (rubber-stamped :-} )
5 years, 8 months ago (2015-04-27 12:21:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103533002/200001
5 years, 8 months ago (2015-04-27 12:23:04 UTC) #4
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 8 months ago (2015-04-27 12:46:52 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 12:47:03 UTC) #6
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/232b09825c2b1b7c2356f483a1b50c305863ad5f
Cr-Commit-Position: refs/heads/master@{#28075}

Powered by Google App Engine
This is Rietveld 408576698