Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11035071: [cc] Remove all WTF #includes from CCLayerTreeHost (Closed)

Created:
8 years, 2 months ago by enne (OOO)
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, tfarina
Visibility:
Public.

Description

[cc] Remove all WTF #includes from CCLayerTreeHost This transitively involved cleaning up RateLimiter and the types that CCProxy, CCPrioritizedTextureManager, and CCPrioritizedTexture are stored in. BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160623

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -114 lines) Patch
M cc/BitmapCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/BitmapCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/BitmapSkPictureCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/BitmapSkPictureCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDelegatedRendererLayerImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHost.h View 8 chunks +20 lines, -11 lines 0 comments Download
M cc/CCLayerTreeHost.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHostTest.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCPrioritizedTexture.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/CCPrioritizedTextureManager.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/CCPrioritizedTextureTest.cpp View 13 chunks +29 lines, -29 lines 0 comments Download
M cc/CCSingleThreadProxy.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/CCSingleThreadProxy.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCThreadProxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCThreadProxy.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M cc/FrameBufferSkPictureCanvasLayerTextureUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ImageLayerChromium.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/LayerTextureUpdater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/LayerTextureUpdater.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/RateLimiter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/RateLimiter.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/TiledLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
https://codereview.chromium.org/11035071/diff/1/cc/CCLayerTreeHost.h File cc/CCLayerTreeHost.h (right): https://codereview.chromium.org/11035071/diff/1/cc/CCLayerTreeHost.h#newcode26 cc/CCLayerTreeHost.h:26: #if defined(COMPILER_GCC) hmm, why's this COMPILER_GCC guarded?
8 years, 2 months ago (2012-10-07 19:31:09 UTC) #1
enne (OOO)
https://codereview.chromium.org/11035071/diff/1/cc/CCLayerTreeHost.h File cc/CCLayerTreeHost.h (right): https://codereview.chromium.org/11035071/diff/1/cc/CCLayerTreeHost.h#newcode26 cc/CCLayerTreeHost.h:26: #if defined(COMPILER_GCC) On 2012/10/07 19:31:09, jamesr wrote: > hmm, ...
8 years, 2 months ago (2012-10-07 19:33:54 UTC) #2
jamesr
lgtm
8 years, 2 months ago (2012-10-07 21:49:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11035071/1031
8 years, 2 months ago (2012-10-08 00:41:01 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-08 03:09:16 UTC) #5 
Change committed as 160623

Powered by Google App Engine
This is Rietveld 408576698