Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/common/browser_plugin_messages.h

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin_messages.h
diff --git a/content/common/browser_plugin_messages.h b/content/common/browser_plugin_messages.h
index 69de1ee9c191ae663cd3547a57cbb0431514c54b..8b289523ba05d8b27628d6e83a90a0f0f1c6e9a1 100644
--- a/content/common/browser_plugin_messages.h
+++ b/content/common/browser_plugin_messages.h
@@ -174,26 +174,18 @@ IPC_MESSAGE_CONTROL4(BrowserPluginMsg_LoadRedirect,
GURL /* new_url */,
bool /* is_top_level */)
-IPC_STRUCT_BEGIN(BrowserPluginMsg_DidNavigate_Params)
Fady Samuel 2012/10/15 19:59:20 We still need these params for CanGoBack/CanGoForw
irobert 2012/10/16 01:26:39 Done.
irobert 2012/10/16 01:26:39 Done.
- // The current URL of the guest.
- IPC_STRUCT_MEMBER(GURL, url)
- // Indicates whether the navigation was on the top-level frame.
- IPC_STRUCT_MEMBER(bool, is_top_level)
- // Chrome's process ID for the guest.
- IPC_STRUCT_MEMBER(int, process_id)
- // The index of the current navigation entry after this navigation was
- // committed.
- IPC_STRUCT_MEMBER(int, current_entry_index)
- // The number of navigation entries after this navigation was committed.
- IPC_STRUCT_MEMBER(int, entry_count)
-IPC_STRUCT_END()
-
// When the guest navigates, the browser process informs the embedder through
-// the BrowserPluginMsg_DidNavigate message along with information about the
-// guest's current navigation state.
-IPC_MESSAGE_CONTROL2(BrowserPluginMsg_DidNavigate,
+// the BrowserPluginMsg_LoadStop message.
+IPC_MESSAGE_CONTROL1(BrowserPluginMsg_LoadStop,
+ int /* instance_id */)
+
+// When all the guest pages have completed, the browser process informs
+// the embedder through the BrowserPluginMsg_DidCommit message.
+IPC_MESSAGE_CONTROL4(BrowserPluginMsg_LoadCommit,
int /* instance_id */,
- BrowserPluginMsg_DidNavigate_Params)
+ GURL /* url */,
+ int /* process_id */,
+ bool /* is_top_level */)
// When the guest crashes, the browser process informs the embedder through this
// message.

Powered by Google App Engine
This is Rietveld 408576698