Collect user logs that debugd can not access

Collect user logs that debugd can not access
    
Debugd can't access anything inside a user's cryptohome. So,
get a list of user logs files to collect from debugd, and
then read them.

BUG=chromium-os:34817
TEST=Navigate to chrome://system and verify chrome_user_log, login-times
     and logout-times now show up.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166065

[gauravsh, 2012-10-02 00:13:36]

So, another alternative way of doing this (much less code) would be to use "cat"
using the command line log source. However, there's some talk of deprecating it,
so I went with this first.

Specifically, there are some open questions about whether it's preferable to let
Chrome collect logs for which it has permissions, versus giving debugd more
powers to collect logs it doesn't yet have permissions for.

[gauravsh, 2012-10-08 16:19:30]

Dave Moore: ping?

[DaveMoore, 2012-10-08 18:10:28]

http://codereview.chromium.org/11035014/diff/1/chrome/browser/chromeos/system...
File chrome/browser/chromeos/system_logs/user_log_source.cc (right):

http://codereview.chromium.org/11035014/diff/1/chrome/browser/chromeos/system...
chrome/browser/chromeos/system_logs/user_log_source.cc:38: {"chrome_user_log",
"/home/chronos/user/log/chrome"},
I would prefer that the knowledge about exactly what logs we're reading resides
in the server so it can be changed without needing changes to Chrome.

[gauravsh, 2012-10-08 18:13:59]

http://codereview.chromium.org/11035014/diff/1/chrome/browser/chromeos/system...
File chrome/browser/chromeos/system_logs/user_log_source.cc (right):

http://codereview.chromium.org/11035014/diff/1/chrome/browser/chromeos/system...
chrome/browser/chromeos/system_logs/user_log_source.cc:38: {"chrome_user_log",
"/home/chronos/user/log/chrome"},
On 2012/10/08 18:10:28, DaveMoore wrote:
> I would prefer that the knowledge about exactly what logs we're reading
resides
> in the server so it can be changed without needing changes to Chrome.

When you say server, do you mean the feedback server, or do you mean the debug
daemon?

[gauravsh, 2012-10-26 23:12:35]

davemoore: PTAL, this is ready for review. As discussed, we now grab the list of
log files that Chrome itself must collect   from debugd, instead of hardcoding
it in Chrome source.

[DaveMoore, 2012-11-05 19:43:33]

lgtm modulo nit

http://codereview.chromium.org/11035014/diff/6001/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc (right):

http://codereview.chromium.org/11035014/diff/6001/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc:69:
weak_ptr_factory_.GetWeakPtr()));
nit: indenting wrong

[commit-bot: I haz the power, 2012-11-05 20:20:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11035014/12001

[commit-bot: I haz the power, 2012-11-05 20:27:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-05 21:00:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11035014/12001

[commit-bot: I haz the power, 2012-11-05 23:07:07]

Change committed as 166065