Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 11035010: cc: Change gtest includes to the style used in chromium. (Closed)

Created:
8 years, 2 months ago by tfarina
Modified:
8 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Change gtest includes to the style used in chromium. BUG=144577 TEST=cc_unittests TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159601

Patch Set 1 #

Patch Set 2 : gmock too #

Patch Set 3 : testSuite -> test_suite #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M cc/CCActiveAnimationTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCDamageTrackerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCDelayBasedTimeSourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCDelegatedRendererLayerImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCDrawQuadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCFrameRateControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCKeyframedAnimationCurveTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerAnimationControllerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerImplTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerIteratorTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerQuadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerSorterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHostCommonTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImplTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/CCMathUtilTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCOcclusionTrackerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCPrioritizedTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCQuadCullerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCRenderPassTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderSurfaceFiltersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderSurfaceTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCRendererGLTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCRendererSoftwareTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCResourceProviderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCSchedulerStateMachineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCSchedulerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCScopedTextureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCScrollbarAnimationControllerLinearFadeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCSolidColorLayerImplTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCThreadTaskTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCThreadedTest.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCThreadedTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTiledLayerImplTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCTimerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/ContentLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/FloatQuadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/LayerChromiumTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ScrollbarLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/TextureCopierTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/TextureLayerChromiumTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ThrottledTextureUploaderTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/TiledLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/TreeSynchronizerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCGeometryTestUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCLayerTestCommon.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/CCSchedulerTestCommon.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/FakeGraphicsContext3DTest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/run_all_unittests.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
TBRing...
8 years, 2 months ago (2012-10-01 20:40:43 UTC) #1
jamesr
I'd prefer you not TBR these sorts of things. If you think reviews are too ...
8 years, 2 months ago (2012-10-01 20:48:06 UTC) #2
tfarina
8 years, 2 months ago (2012-10-01 21:38:39 UTC) #3
On Mon, Oct 1, 2012 at 5:48 PM,  <jamesr@chromium.org> wrote:
> I'd prefer you not TBR these sorts of things.  If you think reviews are too
> slow
> let me know and we can sort it out.
>
Yup. I was not sure if you wanted them TBRed or not. I usually TBR
these kind of changes when I send them to Ben, so that is why I was
doing the same here, based on the same assumption. It's just a way to
move towards faster and don't block others and while I put TBR I
usually wait for the review anyway :)

> lgtm for this
>
> http://codereview.chromium.org/11035010/



-- 
Thiago

Powered by Google App Engine
This is Rietveld 408576698