Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/testrunner/network/endpoint.py

Issue 11035004: Test runner: fix empty patches; better error message for missing test files; correct .gitignore ent… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gitignore ('k') | tools/testrunner/server/work_handler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/network/endpoint.py
diff --git a/tools/testrunner/network/endpoint.py b/tools/testrunner/network/endpoint.py
index 25547c2f15e7f0c87a719bf0a61c80d3347c838e..8350feee5984051ad8c7019a647431bf0d515bac 100644
--- a/tools/testrunner/network/endpoint.py
+++ b/tools/testrunner/network/endpoint.py
@@ -108,7 +108,15 @@ def Execute(workspace, ctx, tests, sock, server):
progress_indicator = EndpointProgress(sock, server, ctx)
runner = execution.Runner(suites, progress_indicator, ctx)
- runner.Run(server.jobs)
+ try:
+ runner.Run(server.jobs)
+ except IOError, e:
+ if e.errno == 2:
+ message = ("File not found: %s, maybe you forgot to 'git add' it?" %
+ e.filename)
+ else:
+ message = "%s" % e
+ compression.Send([-1, message], sock)
progress_indicator.HasRun(None) # Sentinel to signal the end.
progress_indicator.sender_lock.acquire() # Released when sending is done.
progress_indicator.sender_lock.release()
« no previous file with comments | « .gitignore ('k') | tools/testrunner/server/work_handler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698