Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: test/mjsunit/object-seal.js

Issue 1103473003: Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/object-freeze.js ('k') | test/test262-es6/test262-es6.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Tests the Object.seal and Object.isSealed methods - ES 19.1.2.17 and 28 // Tests the Object.seal and Object.isSealed methods - ES 15.2.3.9 and
29 // ES 19.1.2.13 29 // ES 15.2.3.12
30 30
31 // Flags: --allow-natives-syntax --noalways-opt 31 // Flags: --allow-natives-syntax --noalways-opt
32 32
33 // Test that we return obj if non-object is passed as argument 33 // Test that we throw an error if an object is not passed as argument.
34 var non_objects = new Array(undefined, null, 1, -1, 0, 42.43, Symbol("test")); 34 var non_objects = new Array(undefined, null, 1, -1, 0, 42.43);
35 for (var key in non_objects) { 35 for (var key in non_objects) {
36 assertSame(non_objects[key], Object.seal(non_objects[key])); 36 var exception = false;
37 try {
38 Object.seal(non_objects[key]);
39 } catch(e) {
40 exception = true;
41 assertTrue(/Object.seal called on non-object/.test(e));
42 }
43 assertTrue(exception);
37 } 44 }
38 45
39 // Test that isFrozen always returns true for non-objects
40 for (var key in non_objects) { 46 for (var key in non_objects) {
41 assertTrue(Object.isSealed(non_objects[key])); 47 exception = false;
48 try {
49 Object.isSealed(non_objects[key]);
50 } catch(e) {
51 exception = true;
52 assertTrue(/Object.isSealed called on non-object/.test(e));
53 }
54 assertTrue(exception);
42 } 55 }
43 56
44 // Test normal data properties. 57 // Test normal data properties.
45 var obj = { x: 42, z: 'foobar' }; 58 var obj = { x: 42, z: 'foobar' };
46 var desc = Object.getOwnPropertyDescriptor(obj, 'x'); 59 var desc = Object.getOwnPropertyDescriptor(obj, 'x');
47 assertTrue(desc.writable); 60 assertTrue(desc.writable);
48 assertTrue(desc.configurable); 61 assertTrue(desc.configurable);
49 assertEquals(42, desc.value); 62 assertEquals(42, desc.value);
50 63
51 desc = Object.getOwnPropertyDescriptor(obj, 'z'); 64 desc = Object.getOwnPropertyDescriptor(obj, 'z');
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 get: function() { return 42 }, 389 get: function() { return 42 },
377 set: function() { accessorDidRun = true }, 390 set: function() { accessorDidRun = true },
378 configurable: true, 391 configurable: true,
379 enumerable: true 392 enumerable: true
380 }); 393 });
381 obj.data = 'foo'; 394 obj.data = 'foo';
382 assertTrue(%HasFastProperties(obj)); 395 assertTrue(%HasFastProperties(obj));
383 Object.seal(obj); 396 Object.seal(obj);
384 assertTrue(%HasFastProperties(obj)); 397 assertTrue(%HasFastProperties(obj));
385 assertTrue(Object.isSealed(obj)); 398 assertTrue(Object.isSealed(obj));
386
387 function Sealed() {}
388 Object.seal(Sealed);
389 assertDoesNotThrow(function() { return new Sealed(); });
390 Sealed.prototype.prototypeExists = true;
391 assertTrue((new Sealed()).prototypeExists);
OLDNEW
« no previous file with comments | « test/mjsunit/object-freeze.js ('k') | test/test262-es6/test262-es6.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698