Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 1103473003: Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) Reason for revert: [Sheriff] breaks mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 Original issue's description: > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > BUG=v8:3965, v8:3966 > R=arv@chromium.org > LOG=N > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > Cr-Commit-Position: refs/heads/master@{#27985} TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Committed: https://crrev.com/2b97a0e3bc67a366dc02e6567c4f643de0c84690 Cr-Commit-Position: refs/heads/master@{#27990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -119 lines) Patch
M src/v8natives.js View 6 chunks +18 lines, -6 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/object-freeze.js View 2 chunks +20 lines, -68 lines 0 comments Download
M test/mjsunit/object-seal.js View 2 chunks +22 lines, -15 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +26 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions)
5 years, 8 months ago (2015-04-22 07:57:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103473003/1
5 years, 8 months ago (2015-04-22 07:57:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 07:58:05 UTC) #3
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1098243002/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-22 10:33:36 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b97a0e3bc67a366dc02e6567c4f643de0c84690
Cr-Commit-Position: refs/heads/master@{#27990}

Powered by Google App Engine
This is Rietveld 408576698