Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1103413002: Skip gl surface init when headless; enable wm apptests. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip gl surface init when headless; enable wm apptests. Skip native_viewport's init of gfx::GLSurface when headless. Remove the unused --use-osmesa flag (--use-test-config suffices?). Re-enable the window_manager_apptests again; fingers crossed. BUG=480040 TEST=Bot passes window_manager_apptests. R=sky@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/84ba30ab51ce83cd8e4e34fbf5af0301af2033e6 Cr-Commit-Position: refs/heads/master@{#327184}

Patch Set 1 #

Patch Set 2 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M components/native_viewport/main.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M components/native_viewport/public/cpp/args.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/native_viewport/public/cpp/lib/args.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
msw
Hey Scott; please take a look; thanks! (sorry for the churn here!)
5 years, 8 months ago (2015-04-27 22:57:47 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-27 23:46:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103413002/20001
5 years, 8 months ago (2015-04-27 23:49:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59415)
5 years, 8 months ago (2015-04-27 23:57:11 UTC) #6
msw
TBR'ing jochen@chromium.org for components/OWNERS. (sky is adding new OWNERS files as we speak!)
5 years, 8 months ago (2015-04-28 00:00:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103413002/20001
5 years, 8 months ago (2015-04-28 00:02:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-28 00:06:41 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 00:07:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84ba30ab51ce83cd8e4e34fbf5af0301af2033e6
Cr-Commit-Position: refs/heads/master@{#327184}

Powered by Google App Engine
This is Rietveld 408576698