Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 11034023: Remove temporary hack for throttling inlining. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_inliner.cc
===================================================================
--- runtime/vm/flow_graph_inliner.cc (revision 13116)
+++ runtime/vm/flow_graph_inliner.cc (working copy)
@@ -22,8 +22,6 @@
DEFINE_FLAG(charp, inlining_filter, NULL, "Inline only in named function");
DEFINE_FLAG(int, inlining_size_threshold, 250,
"Inline only functions with up to threshold instructions");
-DEFINE_FLAG(int, inlining_growth_factor, 3,
- "Stop inlining when a function grows by the factor");
DEFINE_FLAG(bool, inline_control_flow, true,
"Inline functions with control flow.");
DECLARE_FLAG(bool, print_flow_graph);
@@ -193,20 +191,6 @@
return false;
}
- // If the growth factor is more than threshold abort.
- double growth =
- static_cast<double>(inlined_size_ + size) /
- static_cast<double>(initial_size_);
- if (growth > static_cast<double>(FLAG_inlining_growth_factor)) {
- function.set_is_inlinable(false);
- isolate->set_long_jump_base(base);
- isolate->set_deopt_id(prev_deopt_id);
- isolate->set_ic_data_array(prev_ic_data.raw());
- TRACE_INLINING(OS::Print(" Bailout: growth factor %f\n",
- growth));
- return false;
- }
-
// TODO(zerny): If effort is less than threshold then inline recursively.
// Plug result in the caller graph.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698