Issue 11034002: fix position of close buttons in linux tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11034002: fix position of close buttons in linux tabs (Closed)

Created:
8 years, 2 months ago by Evan Stade

Modified:
8 years, 2 months ago

Reviewers:
Kyle Horimoto, Elliot Glaysher, dpapad

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix position of close buttons in linux tabs I don't know what has caused the recent regression, but this fixes it. The position of the close button is not consistent between windows and mac, I chose to follow mac. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162306

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : kick try bots #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc	View	1	3 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

erg for review khorimoto and dpapad, could you both apply the patch, create a few ...

8 years, 2 months ago (2012-10-16 03:52:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11034002/2001

8 years, 2 months ago (2012-10-17 00:06:34 UTC) #4

commit-bot: I haz the power

8 years, 2 months ago (2012-10-17 02:33:15 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/11034002/14001

Expand Messages | Collapse Messages