Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1103383003: Don't allow CoreAudioUtil::IsSupported() to reinitialize COM. (Closed)

Created:
5 years, 8 months ago by DaleCurtis
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow CoreAudioUtil::IsSupported() to reinitialize COM. I introduced this change in http://crrev.com/324246 but I now think it's incorrect based on the fact that the UI thread should already have COM initialized. BUG=422522 TEST=audio plays Committed: https://crrev.com/84c468567142e212b6c07ffc12458d9e5a797192 Cr-Commit-Position: refs/heads/master@{#327244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M media/audio/win/core_audio_util_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
DaleCurtis
5 years, 8 months ago (2015-04-28 01:56:44 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-28 06:54:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103383003/1
5 years, 8 months ago (2015-04-28 06:54:54 UTC) #5
tommi (sloooow) - chröme
Thanks for fixing. I guess I could have told you about the problems the previous ...
5 years, 8 months ago (2015-04-28 06:56:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 08:03:30 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 08:04:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c468567142e212b6c07ffc12458d9e5a797192
Cr-Commit-Position: refs/heads/master@{#327244}

Powered by Google App Engine
This is Rietveld 408576698