Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1103343005: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/autocomplete,banners,background (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews, James Su, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/autocomplete, banners, background and bitmap_fetcher modules BUG=466848 Committed: https://crrev.com/f073e7707caec577ad43b4c9e0b1c5c5437a51c9 Cr-Commit-Position: refs/heads/master@{#327647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/autocomplete/in_memory_url_index.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/banners/app_banner_data_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bitmap_fetcher/bitmap_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
anujsharma
pkasting@chromium.org: Please review changes in chrome/browser/autocomplete thestig@chromium.org: Please review changes in chrome/browser/
5 years, 7 months ago (2015-04-29 09:59:16 UTC) #2
Lei Zhang
lgtm Considering there's ~49 files that still use DCHECK(content::BrowserThread::CurrentlyOn()) in chrome/browser, I would just convert ...
5 years, 7 months ago (2015-04-29 19:56:12 UTC) #3
Peter Kasting
LGTM What thestig said, also feel free to have one top-level owner reviewer the whole ...
5 years, 7 months ago (2015-04-29 21:18:25 UTC) #4
anujsharma
On 2015/04/29 21:18:25, Peter Kasting wrote: > LGTM > > What thestig said, also feel ...
5 years, 7 months ago (2015-04-30 02:10:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103343005/1
5 years, 7 months ago (2015-04-30 02:11:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 03:10:15 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 03:11:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f073e7707caec577ad43b4c9e0b1c5c5437a51c9
Cr-Commit-Position: refs/heads/master@{#327647}

Powered by Google App Engine
This is Rietveld 408576698