Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1103343003: [chrome/chrome_watcher] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 8 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome watcher module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/c8c0ede792816b36fb0bfae90549190794748ffd Cr-Commit-Position: refs/heads/master@{#327363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pranay
PTAL
5 years, 8 months ago (2015-04-28 05:33:12 UTC) #2
erikwright (departed)
LGTM
5 years, 7 months ago (2015-04-28 17:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103343003/1
5 years, 7 months ago (2015-04-28 18:51:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 21:00:25 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 21:01:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8c0ede792816b36fb0bfae90549190794748ffd
Cr-Commit-Position: refs/heads/master@{#327363}

Powered by Google App Engine
This is Rietveld 408576698