Issue 1103343002: Fix windows-specific usage of CFX_WideStr::operator LPCWSTR().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1103343002: Fix windows-specific usage of CFX_WideStr::operator LPCWSTR(). (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	core/include/fxge/fx_ge_win32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcrt/fx_basic_util.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Bruce, I built this out locally on windows, and found the following were not addressed ...

5 years, 7 months ago (2015-04-27 20:01:23 UTC) #1

Tom Sepez

5 years, 7 months ago (2015-04-27 20:12:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
99ee3d3527bc00f83f01e1db007d190a6b3458f5 (presubmit successful).