Issue 1103323004: ui/base/dragdrop: Fix warnings found by clang chromium-style plugin on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1103323004: ui/base/dragdrop: Fix warnings found by clang chromium-style plugin on Windows. (Closed)

Created:
5 years, 7 months ago by tfarina

Modified:
5 years, 7 months ago

Reviewers:
Nico, sky

CC:
chromium-reviews, dcheng

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ui/base/dragdrop: Fix warnings found by clang chromium-style plugin on Windows. http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/622/steps/compile/logs/stdio This fixes the following kind or warnings: warning(clang): [chromium-style] Complex constructor has an inlined body. warning(clang): [chromium-style] Complex destructor has an inline body. BUG=467287 R=thakis@chromium.org,sky@chromium.org Committed: https://crrev.com/62141ba51cb3109fa2eb8c304bd52b099fc73f4f Cr-Commit-Position: refs/heads/master@{#327296}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -11 lines)			Patch
	M	ui/base/dragdrop/os_exchange_data_provider_win.h	View		1 chunk	+2 lines, -11 lines	0 comments	Download
	M	ui/base/dragdrop/os_exchange_data_provider_win.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103323004/1

5 years, 7 months ago (2015-04-28 16:01:38 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 16:12:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/62141ba51cb3109fa2eb8c304bd52b099fc73f4f
Cr-Commit-Position: refs/heads/master@{#327296}