Eliminate the check for ANDROID_LARGE_MEMORY in jpeg decoders

src/codec/SkJpegDecoderMgr.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkJpegDecoderMgr.h"
 #include "SkJpegUtility.h"
 
@@ skipping 14 matching lines @@
 }
 static void output_message(j_common_ptr info) {
     print_message(info, "output_message");
 }
 
 /*
  * Choose the size of the memory buffer on Android
  */
 static void overwrite_mem_buffer_size(jpeg_decompress_struct* dinfo) {
 #ifdef SK_BUILD_FOR_ANDROID
-
-// Use 30 MB for devices with a large amount of system memory and 5MB otherwise
-// TODO: (msarett) This matches SkImageDecoder.  Why were these values chosen?
-#ifdef ANDROID_LARGE_MEMORY_DEVICE
+    // We can use a large chunk of memory on all currently supported Android devices
     dinfo->mem->max_memory_to_use = 30 * 1024 * 1024;

[scroggo, 2015/04/27 20:05:58]

Why do we use this value? I think I saw in your notes that libjpeg's default is
10MB. Do we know better than libjpeg? (We might - I would believe that was an
old value that does not mean anything today.)

As written, we'll use a different number (the default, which I think is lower)
for non-Android platforms. Any reason for Android to be different?

[scroggo, 2015/04/27 20:24:31]

I think I've answered my own question: at least when we're building libjpeg (and
when Chrome builds it), we use jmemnobs.c, which ignores this value.

Please remove this whole function, which no longer does anything.

-#else
-    dinfo->mem->max_memory_to_use = 5 * 1024 * 1024;
-#endif
-
 #endif // SK_BUILD_FOR_ANDROID
 }
 
 bool JpegDecoderMgr::returnFalse(const char caller[]) {
     print_message((j_common_ptr) &fDInfo, caller);
     return false;
 }
 
 SkCodec::Result JpegDecoderMgr::returnFailure(const char caller[], SkCodec::Result result) {
     print_message((j_common_ptr) &fDInfo, caller);
@@ skipping 46 matching lines @@
     }
 }
 
 jmp_buf& JpegDecoderMgr::getJmpBuf() {
     return fErrorMgr.fJmpBuf;
 }
 
 jpeg_decompress_struct* JpegDecoderMgr::dinfo() {
     return &fDInfo;
 }