Sets ios_product_name and ios_breakpad flags for iOS.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 961 matching lines @@
             'linux_breakpad%': 1,
           }],
           # All Chrome builds have breakpad symbols, but only process the
           # symbols from official builds.
           ['(branding=="Chrome" and buildtype=="Official")', {
             'linux_dump_symbols%': 1,
           }],
         ],
       }],  # os_posix==1 and OS!="mac" and OS!="ios"
       ['OS=="ios"', {
+        # Features unavailable on ios.

[stuartmorgan, 2012/10/05 12:08:45]

Remove this; it's not informative, and isn't actually correct for the block. (It
should come out of the internal tree too.)

[pkl (ping after 24h if needed), 2012/10/05 15:27:09]

Done.

         'disable_nacl%': 1,
         'enable_gpu%': 0,
         'icu_use_data_file_flag%': 1,
         'use_system_bzip2%': 1,
         'use_system_libxml%': 1,
         'use_system_sqlite%': 1,
 
         # The Mac SDK is set for iOS builds and passed through to Mac
         # sub-builds. This allows the Mac sub-build SDK in an iOS build to be
         # overridden from the command line the same way it is for a Mac build.
         'mac_sdk%': '<!(python <(DEPTH)/build/mac/find_sdk.py 10.6)',
-      }],
+
+        'conditions': [
+          # ios_product_name is set to the name of the .app bundle as it should
+          # appear on disk.
+          ['(branding=="Chrome" and buildtype=="Official")', {
+            'ios_breakpad%': 1,

[stuartmorgan, 2012/10/05 12:08:45]

This doesn't match what we do on Mac; as I mentioned before, fixing that should
be part of this CL.

[pkl (ping after 24h if needed), 2012/10/05 15:27:09]

I looked at the find_sdk.py invocation for Mac. It uses --verify which is
different from the non-upstream version. I preserved the logic used downstream.

+            'ios_product_name%': 'Chrome',
+          }, { # else: branding!="Chrome"
+            'ios_breakpad%': 0,
+            'ios_product_name%': 'Chromium',
+          }],
+        ],
+      }],  # OS=="ios"
       ['OS=="android"', {
         # Location of Android NDK.
         'variables': {
           'variables': {
             'variables': {
               'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
             },
             'android_ndk_root%': '<(android_ndk_root)',
             'conditions': [
               ['target_arch == "ia32"', {
@@ skipping 2512 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }