Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 11033014: Revert "Adding a high-resolution timer to platform win32." (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow
Modified:
8 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev, caseq
Visibility:
Public.

Description

Revert "Adding a high-resolution timer to platform win32." This reverts r12651. Committed: https://code.google.com/p/v8/source/detail?r=12652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M src/platform-win32.cc View 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
8 years, 2 months ago (2012-10-02 11:05:57 UTC) #1
ulan
lgtm
8 years, 2 months ago (2012-10-02 11:06:34 UTC) #2
Jakob Kummerow
For the record: there were compile failures: http://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/4390/steps/compile/logs/stdio
8 years, 2 months ago (2012-10-02 11:07:13 UTC) #3
tka
8 years, 2 months ago (2012-10-02 12:06:26 UTC) #4
I want to point at my related issue 882 which seems to be happily ignored (not
that it matters to me)

http://code.google.com/p/v8/issues/detail?id=882

The old code wraps around every 70 minutes because the multiplication is done as
32-bit integers (unlike the other platforms which do the multiplication as
64-bit integers).

So if you change this consider that issue to get it right this time and/or be
able to close this issue.

Powered by Google App Engine
This is Rietveld 408576698