Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5711)

Unified Diff: chrome/browser/ui/views/frame/global_menu_bar_x11.cc

Issue 1103293004: Use ICU plural syntax in more place (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment in generated_strings.grd Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/global_menu_bar_x11.cc
diff --git a/chrome/browser/ui/views/frame/global_menu_bar_x11.cc b/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
index d7756f5866d3d355261e35047b2344b4a2d54788..e20aa433ccf547ddbc4a2d845cd3772699b59675 100644
--- a/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
+++ b/chrome/browser/ui/views/frame/global_menu_bar_x11.cc
@@ -761,12 +761,8 @@ void GlobalMenuBarX11::TabRestoreServiceChanged(TabRestoreService* service) {
HistoryItem* item = new HistoryItem();
item->session_id = entry_win->id;
- std::string title = tabs.size() == 1 ?
- l10n_util::GetStringUTF8(
- IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_SINGLE) :
- l10n_util::GetStringFUTF8(
- IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_MULTIPLE,
- base::IntToString16(tabs.size()));
+ std::string title = l10n_util::GetPluralStringFUTF8(
+ IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW, tabs.size());
Peter Kasting 2015/05/01 21:11:29 Nit: Strange indenting here I'd probably just inl
DbusmenuMenuitem* parent_item = BuildMenuItem(
title, TAG_RECENTLY_CLOSED);
menuitem_child_add_position(history_menu_, parent_item, index++);

Powered by Google App Engine
This is Rietveld 408576698