Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: chrome/app/chromium_strings.grd

Issue 1103293004: Use ICU plural syntax in more place (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment in generated_strings.grd Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chromium_strings.grd
diff --git a/chrome/app/chromium_strings.grd b/chrome/app/chromium_strings.grd
index 1ee0233f28ffa88465fb033deb4a7f622a940e72..d1137298887f634e0ff8a208f6ffb0fb75183b08 100644
--- a/chrome/app/chromium_strings.grd
+++ b/chrome/app/chromium_strings.grd
@@ -640,15 +640,25 @@ Chromium is unable to recover your settings.
</message>
<!-- Remove in-progress downloads confirmation dialog -->
- <message name="IDS_SINGLE_DOWNLOAD_REMOVE_CONFIRM_EXPLANATION" desc="Explanation of the dialog asking for user confirmation to close the browser when one download is in progress.">
- A download is currently in progress. Do you want to exit Chromium and cancel the download?
+ <message name="IDS_DOWNLOAD_REMOVE_CONFIRM_EXPLANATION" desc="Explanation of the dialog asking for user confirmation to close the browser when one or more downloads are in progress. [ICU Syntax]">
+ {NUM_DOWNLOAD, plural,
+ =1 {A download is currently in progress. Do you want to cancel the download and exit Chromium?}
+ other {# downloads are currently in progress. Do you want to cancel the downloads and exit Chromium?}}
</message>
- <message name="IDS_MULTIPLE_DOWNLOADS_REMOVE_CONFIRM_EXPLANATION" desc="Explanation of the dialog asking for user confirmation to close the browser when multiple downloads are in progress.">
- Downloads are currently in progress. Do you want to exit Chromium and cancel the downloads?
+ <if expr="is_macosx">
+ <message name="IDS_DOWNLOAD_REMOVE_CONFIRM_OK_BUTTON_LABEL" desc="In Title Case: Button text for OKing to and close the browser when one or more downloads are in progress. If necessary, add '#' for plural cases. [ICU Syntax]">
Peter Kasting 2015/05/01 21:11:28 Nit: I think you mean "...for canceling the downlo
jungshik at Google 2015/05/01 22:25:58 Ick. Copy'n'paste .... Thanks
+ {NUM_DOWNLOAD, plural,
+ =1 {Cancel Download and Quit Chromium}
Peter Kasting 2015/05/01 21:11:28 These more verbose strings are descriptive, but I'
shrike 2015/05/01 21:51:40 Sorry, and will do.
jungshik at Google 2015/05/01 22:25:58 A good catch. I was worried about it and meant to
+ other {Cancel Downloads and Quit Chromium}}
</message>
- <message name="IDS_DOWNLOAD_REMOVE_CONFIRM_OK_BUTTON_LABEL" desc="Button text for OKing to close the browser when one or more downloads are in progress.">
- Yes, exit Chromium
+ </if>
+ <if expr="not is_macosx">
+ <message name="IDS_DOWNLOAD_REMOVE_CONFIRM_OK_BUTTON_LABEL" desc="Button text for OKing to and close the browser when one or more downloads are in progress. If necessary, add '#' for plural cases. [ICU Syntax]">
+ {NUM_DOWNLOAD, plural,
+ =1 {Cancel download and exit Chromium}
+ other {Cancel downloads and exit Chromium}}
</message>
+ </if>
<!-- Quit all apps confirmation dialog -->
<if expr="is_macosx">
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')

Powered by Google App Engine
This is Rietveld 408576698