Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/api/device_permissions_prompt.cc

Issue 1103293004: Use ICU plural syntax in more place (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: recently_closed.js restored per estade Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/global_menu_bar_x11.cc ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/device_permissions_prompt.cc
diff --git a/extensions/browser/api/device_permissions_prompt.cc b/extensions/browser/api/device_permissions_prompt.cc
index 66aff350a7b7afe20909e589f824753855bb7246..b2df4726b2591a0771d6c0f4e2c2e4efb1e0dc31 100644
--- a/extensions/browser/api/device_permissions_prompt.cc
+++ b/extensions/browser/api/device_permissions_prompt.cc
@@ -90,9 +90,8 @@ class UsbDevicePermissionsPrompt : public DevicePermissionsPrompt::Prompt,
}
base::string16 GetHeading() const override {
- return l10n_util::GetStringUTF16(
- multiple() ? IDS_USB_DEVICE_PERMISSIONS_PROMPT_TITLE_MULTIPLE
- : IDS_USB_DEVICE_PERMISSIONS_PROMPT_TITLE_SINGLE);
+ return l10n_util::GetPluralStringFUTF16(
+ IDS_HID_DEVICE_PERMISSIONS_PROMPT_TITLE, devices_.size());
}
void Dismissed() override {
@@ -205,9 +204,8 @@ class HidDevicePermissionsPrompt : public DevicePermissionsPrompt::Prompt,
}
base::string16 GetHeading() const override {
- return l10n_util::GetStringUTF16(
- multiple() ? IDS_HID_DEVICE_PERMISSIONS_PROMPT_TITLE_MULTIPLE
- : IDS_HID_DEVICE_PERMISSIONS_PROMPT_TITLE_SINGLE);
+ return l10n_util::GetPluralStringFUTF16(
+ IDS_USB_DEVICE_PERMISSIONS_PROMPT_TITLE, devices_.size());
}
void Dismissed() override {
@@ -305,6 +303,7 @@ void DevicePermissionsPrompt::Prompt::SetObserver(Observer* observer) {
}
base::string16 DevicePermissionsPrompt::Prompt::GetPromptMessage() const {
+ // TODO(jungshik): Consider using the ICU syntax once bug 481734 is fixed.
return l10n_util::GetStringFUTF16(multiple_
? IDS_DEVICE_PERMISSIONS_PROMPT_MULTIPLE
: IDS_DEVICE_PERMISSIONS_PROMPT_SINGLE,
« no previous file with comments | « chrome/browser/ui/views/frame/global_menu_bar_x11.cc ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698