Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc

Issue 1103293004: Use ICU plural syntax in more place (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: recently_closed.js restored per estade Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
index 355b33e32d63d9ddc219cb3537fdbf56063602a8..e53fa02f35d0bc3927116eae65959081e081f398 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
@@ -534,14 +534,8 @@ void RecentTabsSubMenuModel::BuildLocalWindowItem(
int curr_model_index) {
int command_id = WindowVectorIndexToCommandId(local_window_items_.size());
// See comments in BuildLocalEntries() about usage of InsertItem*At().
- if (num_tabs == 1) {
- InsertItemWithStringIdAt(curr_model_index, command_id,
- IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_SINGLE);
- } else {
- InsertItemAt(curr_model_index, command_id, l10n_util::GetStringFUTF16(
- IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_MULTIPLE,
- base::IntToString16(num_tabs)));
- }
+ InsertItemAt(curr_model_index, command_id, l10n_util::GetPluralStringFUTF16(
+ IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW, num_tabs));
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
SetIcon(curr_model_index, rb.GetNativeImageNamed(IDR_RECENTLY_CLOSED_WINDOW));
local_window_items_.push_back(window_id);
« no previous file with comments | « chrome/browser/ui/cocoa/history_menu_bridge.mm ('k') | chrome/browser/ui/views/download/download_in_progress_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698