Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103293002: [iOS] Upstream iOS geolocation code (Closed)

Created:
5 years, 8 months ago by droger
Modified:
5 years, 7 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream iOS geolocation code Committed: https://crrev.com/fb3e2efd4d435c32363b42d22386d59ff2fec971 Cr-Commit-Position: refs/heads/master@{#327249}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+895 lines, -0 lines) Patch
A ios/chrome/browser/geolocation/CLLocation+OmniboxGeolocation.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/CLLocation+OmniboxGeolocation.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/CLLocation+XGeoHeader.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/CLLocation+XGeoHeader.mm View 1 chunk +74 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm View 1 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/location_manager.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/location_manager.mm View 1 chunk +150 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/location_manager+Testing.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/location_manager_unittest.mm View 1 1 chunk +107 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/omnibox_geolocation_config.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/omnibox_geolocation_config.mm View 1 chunk +81 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/test_location_manager.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/browser/geolocation/test_location_manager.mm View 1 chunk +67 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +9 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/provider/ios_provider_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/geolocation_updater_provider.h View 1 chunk +89 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/geolocation_updater_provider.mm View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
droger
5 years, 7 months ago (2015-04-28 08:19:28 UTC) #2
sdefresne
lgtm https://codereview.chromium.org/1103293002/diff/1/ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm File ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm (right): https://codereview.chromium.org/1103293002/diff/1/ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm#newcode5 ios/chrome/browser/geolocation/CLLocation+XGeoHeaderTest.mm:5: #import <CoreLocation/CoreLocation.h> style: newline after this #include https://codereview.chromium.org/1103293002/diff/1/ios/chrome/browser/geolocation/location_manager.h ...
5 years, 7 months ago (2015-04-28 08:34:39 UTC) #3
droger
Thanks for the review. All done.
5 years, 7 months ago (2015-04-28 08:41:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103293002/20001
5 years, 7 months ago (2015-04-28 08:41:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 09:14:50 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 09:15:44 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fb3e2efd4d435c32363b42d22386d59ff2fec971
Cr-Commit-Position: refs/heads/master@{#327249}

Powered by Google App Engine
This is Rietveld 408576698