Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: chrome/browser/media/router/issue_unittest.cc

Issue 1103273013: Upstream the Media Router's Issue class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added issue manager, issue observer. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/media/router/issue.h"
6 #include "chrome/grit/generated_resources.h"
7 #include "testing/gmock/include/gmock/gmock.h"
8 #include "ui/base/l10n/l10n_util.h"
9
10 namespace media_router {
11
12 class IssueUnitTest : public ::testing::Test {
DaleCurtis 2015/04/30 18:18:15 Just use TEST() instead of TEST_F() and you can re
Kevin M 2015/05/01 17:59:18 Done.
13 public:
14 IssueUnitTest() {}
15 ~IssueUnitTest() override {}
16
17 private:
18 DISALLOW_COPY_AND_ASSIGN(IssueUnitTest);
19 };
20
21 // Checks static IssueAction factory method.
22 TEST_F(IssueUnitTest, IssueActionConstructor) {
23 // Pre-defined "Ok" issue action.
24 IssueAction action1(IssueAction::OK);
25 EXPECT_EQ(IssueAction::OK, action1.type());
26
27 // Pre-defined "Cancel" issue action.
28 IssueAction action2(IssueAction::CANCEL);
29 EXPECT_EQ(IssueAction::CANCEL, action2.type());
30 }
31
32 // Tests custom Issue factory method without any secondary actions.
33 TEST_F(IssueUnitTest, CustomIssueConstructionWithNoSecondaryActions) {
34 std::vector<IssueAction> secondary_actions;
35 std::string title = "title";
36 std::string message = "message";
37
38 Issue issue1(title, message, IssueAction(IssueAction::OK), secondary_actions,
39 "", Issue::WARNING, false, "http://www.google.com/");
40
41 EXPECT_EQ(title, issue1.title());
42 EXPECT_EQ(message, issue1.message());
43 EXPECT_EQ(IssueAction::OK, issue1.default_action().type());
44 EXPECT_TRUE(issue1.secondary_actions().empty());
45 EXPECT_EQ(Issue::WARNING, issue1.severity());
46 EXPECT_EQ("", issue1.route_id());
47 EXPECT_TRUE(issue1.IsGlobal());
48 EXPECT_FALSE(issue1.IsBlocking());
49 EXPECT_EQ("http://www.google.com/", issue1.help_url().spec());
50
51 Issue issue2(title, message, IssueAction(IssueAction::OK), secondary_actions,
52 "routeid", Issue::FATAL, true, "http://www.google.com/");
53
54 EXPECT_EQ(title, issue2.title());
55 EXPECT_EQ(message, issue2.message());
56 EXPECT_EQ(IssueAction::OK, issue1.default_action().type());
57 EXPECT_TRUE(issue2.secondary_actions().empty());
58 EXPECT_EQ(Issue::FATAL, issue2.severity());
59 EXPECT_EQ("routeid", issue2.route_id());
60 EXPECT_FALSE(issue2.IsGlobal());
61 EXPECT_TRUE(issue2.IsBlocking());
62 EXPECT_EQ("http://www.google.com/", issue1.help_url().spec());
63
64 Issue issue3(title, "", IssueAction(IssueAction::OK), secondary_actions,
65 "routeid", Issue::FATAL, true, "http://www.google.com/");
66
67 EXPECT_EQ(title, issue3.title());
68 EXPECT_EQ("", issue3.message());
69 EXPECT_EQ(IssueAction::OK, issue1.default_action().type());
70 EXPECT_TRUE(issue3.secondary_actions().empty());
71 EXPECT_EQ(Issue::FATAL, issue3.severity());
72 EXPECT_EQ("routeid", issue3.route_id());
73 EXPECT_FALSE(issue3.IsGlobal());
74 EXPECT_TRUE(issue3.IsBlocking());
75 EXPECT_EQ("http://www.google.com/", issue1.help_url().spec());
76 }
77
78 // Tests custom Issue factory method with secondary actions.
79 TEST_F(IssueUnitTest, CustomIssueConstructionWithSecondaryActions) {
80 std::vector<IssueAction> secondary_actions;
81 secondary_actions.push_back(IssueAction(IssueAction::DISMISS));
82 secondary_actions.push_back(IssueAction(IssueAction::CANCEL));
83 EXPECT_EQ(2u, secondary_actions.size());
84 std::string title = "title";
85 std::string message = "message";
86
87 Issue issue1(title, message, IssueAction(IssueAction::OK), secondary_actions,
88 "", Issue::WARNING, false, "");
89
90 EXPECT_EQ(title, issue1.title());
91 EXPECT_EQ(message, issue1.message());
92 EXPECT_EQ(IssueAction::OK, issue1.default_action().type());
93 EXPECT_FALSE(issue1.secondary_actions().empty());
94 EXPECT_EQ(2u, issue1.secondary_actions().size());
95 EXPECT_EQ(Issue::WARNING, issue1.severity());
96 EXPECT_EQ("", issue1.route_id());
97 EXPECT_TRUE(issue1.IsGlobal());
98 EXPECT_FALSE(issue1.IsBlocking());
99
100 Issue issue2(title, message, IssueAction(IssueAction::OK), secondary_actions,
101 "routeid", Issue::FATAL, true, "");
102
103 EXPECT_EQ(title, issue2.title());
104 EXPECT_EQ(message, issue2.message());
105 EXPECT_EQ(IssueAction::OK, issue2.default_action().type());
106 EXPECT_FALSE(issue2.secondary_actions().empty());
107 EXPECT_EQ(2u, issue2.secondary_actions().size());
108 EXPECT_EQ(Issue::FATAL, issue2.severity());
109 EXPECT_EQ("routeid", issue2.route_id());
110 EXPECT_FALSE(issue2.IsGlobal());
111 EXPECT_TRUE(issue2.IsBlocking());
112
113 Issue issue3(title, "", IssueAction(IssueAction::OK), secondary_actions,
114 "routeid", Issue::FATAL, true, "");
115
116 EXPECT_EQ(title, issue3.title());
117 EXPECT_EQ("", issue3.message());
118 EXPECT_EQ(IssueAction::OK, issue3.default_action().type());
119 EXPECT_FALSE(issue3.secondary_actions().empty());
120 EXPECT_EQ(2u, issue3.secondary_actions().size());
121 EXPECT_EQ(Issue::FATAL, issue3.severity());
122 EXPECT_EQ("routeid", issue3.route_id());
123 EXPECT_FALSE(issue3.IsGlobal());
124 EXPECT_TRUE(issue3.IsBlocking());
125 }
126
127 // Tests == and != method.
128 TEST_F(IssueUnitTest, Equal) {
129 std::vector<IssueAction> secondary_actions;
130 secondary_actions.push_back(IssueAction(IssueAction::DISMISS));
131 secondary_actions.push_back(IssueAction(IssueAction::CANCEL));
132
133 std::vector<IssueAction> secondary_actions2;
134 secondary_actions2.push_back(IssueAction(IssueAction::DISMISS));
135
136 std::string title = "title";
137 std::string message = "message";
138
139 Issue issue1(Issue(title, message, IssueAction(IssueAction::OK),
140 secondary_actions, "", Issue::WARNING, false, ""));
141 EXPECT_TRUE(issue1.Equals(issue1));
142
143 Issue issue2(Issue(title, message, IssueAction(IssueAction::OK),
144 secondary_actions, "", Issue::WARNING, false, ""));
145 EXPECT_FALSE(issue1.Equals(issue2));
146 }
147
148 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698