Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1103273009: Use v8::Local inplace of v8::Handle in src/chrome/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, extensions-reviews_chromium.org, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use v8::Local inplace of v8::Handle in src/chrome/* Replace Handle with Local BUG=424445 Committed: https://crrev.com/6d9098d6f2222c7214d8f3319cd5d5cd53b508c1 Cr-Commit-Position: refs/heads/master@{#327673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -76 lines) Patch
M chrome/renderer/benchmarking_extension.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/external_extension.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/net/net_error_page_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 15 chunks +18 lines, -18 lines 0 comments Download
M chrome/renderer/translate/translate_script_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/v8_unit_test.cc View 7 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-29 13:37:14 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 15:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103273009/1
5 years, 7 months ago (2015-04-30 01:22:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60112)
5 years, 7 months ago (2015-04-30 01:28:17 UTC) #7
deepak.s
5 years, 7 months ago (2015-04-30 01:33:17 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-30 07:24:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103273009/1
5 years, 7 months ago (2015-04-30 07:26:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 07:31:54 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:33:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d9098d6f2222c7214d8f3319cd5d5cd53b508c1
Cr-Commit-Position: refs/heads/master@{#327673}

Powered by Google App Engine
This is Rietveld 408576698