Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1103273005: Mark virtual fast/images/2-dht.html tests as [ ImageOnlyFailure ] (Closed)

Created:
5 years, 7 months ago by Noel Gordon
Modified:
5 years, 7 months ago
Reviewers:
urvang (Google), urvang
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark virtual fast/images/2-dht.html tests as [ ImageOnlyFailure ] virtual/{deferred,slimmingpaint}/fast/images/2-dht.html need a new image rebaseline for the fix for issue 398235 to be submitted. Make them image only failures in TestExpectations (following blink r194511). virtual/slimmingpaint/fast/images/2-dht.html [ ImageOnlyFailure ] virtual/deferred/fast/images/2-dht.html [ ImageOnlyFailure ] NOTRY=true BUG=398235 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Noel Gordon
5 years, 7 months ago (2015-04-28 22:39:33 UTC) #1
urvang (Google)
lgtm
5 years, 7 months ago (2015-04-28 22:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103273005/1
5 years, 7 months ago (2015-04-28 22:48:20 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-04-28 22:53:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194629
5 years, 7 months ago (2015-04-28 22:53:12 UTC) #8
urvang
lgtm (LGTMing from the correct account now)
5 years, 7 months ago (2015-04-28 22:57:09 UTC) #10
Noel Gordon
:)
5 years, 7 months ago (2015-04-28 23:04:06 UTC) #11
Noel Gordon
Either works for a TestExpectations update.
5 years, 7 months ago (2015-04-28 23:04:38 UTC) #12
Noel Gordon
5 years, 7 months ago (2015-04-29 00:31:00 UTC) #13
Message was sent while issue was closed.
Also, I'm pre-testing the fix roll over on
https://codereview.chromium.org/1110113002 to see no other webkit tests break.

Powered by Google App Engine
This is Rietveld 408576698