Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: tools/perf/measurements/oilpan_gc_times_unittest.py

Issue 1103273002: Remove protected-access from tools/perf/pylintrc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/page_cycler.py ('k') | tools/perf/measurements/task_execution_time_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/oilpan_gc_times_unittest.py
diff --git a/tools/perf/measurements/oilpan_gc_times_unittest.py b/tools/perf/measurements/oilpan_gc_times_unittest.py
index 1d9bf5fd3bc5d9c8faa5c087319708281fa16413..9b448d8314f459beba0cdf6170ecb0a34a3eea73 100644
--- a/tools/perf/measurements/oilpan_gc_times_unittest.py
+++ b/tools/perf/measurements/oilpan_gc_times_unittest.py
@@ -63,7 +63,6 @@ class OilpanGCTimesTestData(object):
def ClearResults(self):
self._results = page_test_results.PageTestResults()
-
class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
"""Smoke test for Oilpan GC pause time measurements.
@@ -80,6 +79,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
def setUp(self):
self._options = options_for_unittests.GetCopy()
+ # Disable for accessing private API of _OilpanGCTimesBase.
+ # pylint: disable=protected-access
def testForParsingOldFormat(self):
def getMetric(results, name):
metrics = results.FindAllPageSpecificValuesNamed(name)
@@ -109,6 +110,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
self.assertEquals(2, len(getMetric(results,
'oilpan_forced_complete_sweep')))
+ # Disable for accessing private API of _OilpanGCTimesBase.
+ # pylint: disable=protected-access
def testForParsing(self):
def getMetric(results, name):
metrics = results.FindAllPageSpecificValuesNamed(name)
« no previous file with comments | « tools/perf/benchmarks/page_cycler.py ('k') | tools/perf/measurements/task_execution_time_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698