Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1103263003: Re-enable Trap.SigSysAction test under tsan. (Closed)

Created:
5 years, 8 months ago by hidehiko
Modified:
5 years, 8 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, hamaji, mazda, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable Trap.SigSysAction test under tsan. The reason of Trap.SigSysAction failure under TSAN was identified, which was; TSAN intercepts sigaction(), similar to MSAN. So, direct syscall breaks its assumption. Fallback to sigaction() on TSAN. TEST=Ran bots with tsan. Ran the failure test case with tsan=1 locally. BUG=481297 Committed: https://crrev.com/1fd8cbbab5cfa292bbfd006a7878a2f102195f90 Cr-Commit-Position: refs/heads/master@{#327216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M sandbox/linux/seccomp-bpf/trap_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hidehiko
Thank you for review in advance, - hidehiko
5 years, 8 months ago (2015-04-27 18:57:15 UTC) #2
mdempsky
lgtm Is there any chance that this affects other clang sanitizer modes too? E.g., ASAN?
5 years, 8 months ago (2015-04-27 19:04:37 UTC) #3
hidehiko
On 2015/04/27 19:04:37, mdempsky wrote: > lgtm > > Is there any chance that this ...
5 years, 8 months ago (2015-04-27 19:18:27 UTC) #4
mdempsky
On 2015/04/27 19:18:27, hidehiko wrote: > So I think it's ok. WDYT (especially about ASAN), ...
5 years, 8 months ago (2015-04-27 19:36:59 UTC) #5
hidehiko
On 2015/04/27 19:36:59, mdempsky wrote: > On 2015/04/27 19:18:27, hidehiko wrote: > > So I ...
5 years, 8 months ago (2015-04-28 01:28:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103263003/1
5 years, 8 months ago (2015-04-28 01:28:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 01:32:26 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 01:33:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd8cbbab5cfa292bbfd006a7878a2f102195f90
Cr-Commit-Position: refs/heads/master@{#327216}

Powered by Google App Engine
This is Rietveld 408576698