Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1103253003: PlzNavigate: properly set file access permissions on the RFH (Closed)

Created:
5 years, 7 months ago by clamy
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: properly set file access permissions on the RFH This CL gives appropriate permissions to the RenderFrameHost on NavigationCommit. This allows to run browser tests backed by javascript files on disk with PlzNavigate enabled. BUG=475027 Committed: https://crrev.com/3d638b14a085318d039cff23acfb5692ae6f7150 Cr-Commit-Position: refs/heads/master@{#327328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +28 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
clamy
@nasko: PTAL @carlosk, fdegans: FYI Note that this fixes _a lot_ of browser tests :).
5 years, 7 months ago (2015-04-27 17:12:22 UTC) #2
nasko
LGTM
5 years, 7 months ago (2015-04-28 17:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103253003/1
5 years, 7 months ago (2015-04-28 17:26:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 18:15:04 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 18:16:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d638b14a085318d039cff23acfb5692ae6f7150
Cr-Commit-Position: refs/heads/master@{#327328}

Powered by Google App Engine
This is Rietveld 408576698