Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103233002: Remove maintaing ReadbackRequests for copyFromCompositingSurface. (Closed)

Created:
5 years, 7 months ago by sivag
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, patro
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove maintaing ReadbackRequests for copyFromCompositingSurface. CopyFromCompositingSurface should return immediately if the frame is not available. Bug=472457 Committed: https://crrev.com/145ef46a3701637431503a04af64f78128e70209 Cr-Commit-Position: refs/heads/master@{#327248}

Patch Set 1 #

Patch Set 2 : Rebasing TOT! #

Patch Set 3 : Remove abortpendingreadbacks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -84 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 chunks +0 lines, -26 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 8 chunks +1 line, -58 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sivag
ptal..
5 years, 7 months ago (2015-04-27 14:40:58 UTC) #2
no sievers
lgtm
5 years, 7 months ago (2015-04-27 19:09:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103233002/1
5 years, 7 months ago (2015-04-28 05:23:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/47206) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 05:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103233002/20001
5 years, 7 months ago (2015-04-28 06:29:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/16874)
5 years, 7 months ago (2015-04-28 06:56:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103233002/40001
5 years, 7 months ago (2015-04-28 07:00:43 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 09:12:56 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 09:13:45 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/145ef46a3701637431503a04af64f78128e70209
Cr-Commit-Position: refs/heads/master@{#327248}

Powered by Google App Engine
This is Rietveld 408576698