content/browser/renderer_host/render_widget_host_view_android.h - Issue 1103213003: [Android] Avoid using ContentViewCore when detaching from RWHVAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 1103213003: [Android] Avoid using ContentViewCore when detaching from RWHVAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Proper build Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 462cabde47f61333c9499a8373932be10ecacbee..85a03b2be5311ea2356d742f5744e2a373bc6987 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -330,6 +330,13 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// ContentViewCoreImpl is our interface to the view system.

ContentViewCoreImpl* content_view_core_;

+ // Cache the WindowAndroid instance exposed by ContentViewCore to avoid

+ // calling into ContentViewCore when it is being detached from the

+ // WebContents during destruction. The WindowAndroid has stronger lifetime

+ // guarantees, and should be safe to use for observer detachment.

+ // This will be valid iff |content_view_core_| is valid.

+ ui::WindowAndroid* content_view_core_window_android_;

jdduke (slow) 2015/04/28 18:38:01 I'm not married to this name. |current_window_and

ImeAdapterAndroid ime_adapter_android_;

// Body background color of the underlying document.

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »