Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8492)

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 11032052: Merge 160403 - Fix crash when a download is requested for an outdated plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1287/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_observer.cc
===================================================================
--- chrome/browser/plugins/plugin_observer.cc (revision 160406)
+++ chrome/browser/plugins/plugin_observer.cc (working copy)
@@ -103,8 +103,7 @@
}
void ConfirmInstallDialogDelegate::OnAccepted() {
- installer()->StartInstalling(plugin_metadata_->url_for_display(),
- plugin_metadata_->plugin_url(),
+ installer()->StartInstalling(plugin_metadata_->plugin_url(),
TabContents::FromWebContents(web_contents_));
}
@@ -310,9 +309,7 @@
PluginInstaller* installer,
scoped_ptr<PluginMetadata> plugin_metadata) {
if (plugin_metadata->url_for_display()) {
- installer->OpenDownloadURL(plugin_metadata->url_for_display(),
- plugin_metadata->plugin_url(),
- web_contents());
+ installer->OpenDownloadURL(plugin_metadata->plugin_url(), web_contents());
} else {
TabModalConfirmDialog::Create(
new ConfirmInstallDialogDelegate(
« no previous file with comments | « chrome/browser/plugins/plugin_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698