Merge 160403 - Fix crash when a download is requested for an outdated plugin.

chrome/browser/plugins/plugin_infobar_delegates.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_infobar_delegates.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/google/google_util.h"
@@ skipping 215 matching lines @@
 }
 
 bool OutdatedPluginInfoBarDelegate::Accept() {
   content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Update"));
   if (installer()->state() != PluginInstaller::INSTALLER_STATE_IDLE) {
     NOTREACHED();
     return false;
   }
 
   content::WebContents* web_contents = owner()->GetWebContents();
+  // A call to any of |OpenDownloadURL()| or |StartInstalling()| will
+  // result in deleting ourselves. Accordingly, we make sure to
+  // not pass a reference to an object that can go away.
+  // http://crbug.com/54167
+  GURL plugin_url(plugin_metadata_->plugin_url());
   if (plugin_metadata_->url_for_display()) {
-    installer()->OpenDownloadURL(plugin_metadata_->url_for_display(),
-                                 plugin_metadata_->plugin_url(),
-                                 web_contents);
+    installer()->OpenDownloadURL(plugin_url, web_contents);
   } else {
-    installer()->StartInstalling(
-        plugin_metadata_->url_for_display(),
-        plugin_metadata_->plugin_url(),
-        TabContents::FromWebContents(web_contents));
+    installer()->StartInstalling(plugin_url,
+                                 TabContents::FromWebContents(web_contents));
   }
   return false;
 }
 
 bool OutdatedPluginInfoBarDelegate::Cancel() {
   content::RecordAction(
       UserMetricsAction("OutdatedPluginInfobar.AllowThisTime"));
   LoadBlockedPlugins();
   return true;
 }
@@ skipping 241 matching lines @@
       "https://support.google.com/chrome/?ib_display_in_desktop"));
   OpenURLParams params(
       url, Referrer(),
       (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
       content::PAGE_TRANSITION_LINK, false);
   owner()->GetWebContents()->OpenURL(params);
   return false;
 }
 #endif  // defined(OS_WIN)
 #endif  // defined(ENABLE_PLUGIN_INSTALLATION)