Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1103143002: Revert of [turbofan] Add language mode to JSCallFunction operator. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add language mode to JSCallFunction operator. (patchset #1 id:1 of https://codereview.chromium.org/1107883002/) Reason for revert: [Sheriff] breaks win compile and was committed manually Original issue's description: > [turbofan] Add language mode to JSCallFunction operator. > > Also do some drive-by-cleanup to the unittests. > > R=svenpanne@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/2d827809e0a20fc60faa3be87ba9357bbded4a4c TBR=svenpanne@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -106 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +14 lines, -31 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 6 chunks +58 lines, -64 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [turbofan] Add language mode to JSCallFunction operator.
5 years, 8 months ago (2015-04-27 10:59:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103143002/1
5 years, 8 months ago (2015-04-27 10:59:36 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/compiler/js-operator.h: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-27 10:59:44 UTC) #4
Michael Achenbach
5 years, 8 months ago (2015-04-27 11:04:57 UTC) #5
The committed patch wasn't uploaded to rietveld :/

Powered by Google App Engine
This is Rietveld 408576698