Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11031064: Reland support for firefox jsshell. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/bin/jsshell ('K') | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 13274)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -633,7 +633,8 @@
}
}
- VoidFunction makeReadHandler(StringInputStream source, List<String> destination) {
+ VoidFunction makeReadHandler(StringInputStream source,
+ List<String> destination) {
void handler () {
if (source.closed) return; // TODO(whesse): Remove when bug is fixed.
var line = source.readLine();
@@ -654,8 +655,7 @@
runCommand(testCase.commands[currentStep++], stepExitHandler);
}
- void runCommand(Command command,
- void exitHandler(int exitCode)) {
+ void runCommand(Command command, void exitHandler(int exitCode)) {
process = Process.start(command.executable, command.arguments);
process.onExit = exitHandler;
process.onError = (e) {
« tools/testing/bin/jsshell ('K') | « tools/testing/dart/test_options.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | tools/testing/dart/test_suite.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698