Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3107)

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 11031055: Introduce PlatformBitmap, which is a minimal helper class that wraps an SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.h ('k') | chrome/browser/prerender/prerender_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs.cc
===================================================================
--- chrome/browser/extensions/api/tabs/tabs.cc (revision 161107)
+++ chrome/browser/extensions/api/tabs/tabs.cc (working copy)
@@ -1684,23 +1684,23 @@
error_ = keys::kInternalVisibleTabCaptureError;
return false;
}
- skia::PlatformCanvas* temp_canvas = new skia::PlatformCanvas;
+ skia::PlatformBitmap* temp_bitmap = new skia::PlatformBitmap;
render_view_host->CopyFromBackingStore(
gfx::Rect(),
view->GetViewBounds().size(),
base::Bind(&CaptureVisibleTabFunction::CopyFromBackingStoreComplete,
this,
- base::Owned(temp_canvas)),
- temp_canvas);
+ base::Owned(temp_bitmap)),
+ temp_bitmap);
return true;
}
void CaptureVisibleTabFunction::CopyFromBackingStoreComplete(
- skia::PlatformCanvas* canvas,
+ skia::PlatformBitmap* bitmap,
bool succeeded) {
if (succeeded) {
VLOG(1) << "captureVisibleTab() got image from backing store.";
- SendResultFromBitmap(skia::GetTopDevice(*canvas)->accessBitmap(false));
+ SendResultFromBitmap(bitmap->GetBitmap());
return;
}
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs.h ('k') | chrome/browser/prerender/prerender_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698