Chromium Code Reviews
Help | Chromium Project | Sign in
(417)

Issue 11031002: Prepare push to trunk. Now working on version 3.14.2. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Jakob
Modified:
1 year, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.14.2.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=12641

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Lint Patch
M ChangeLog View 1 1 chunk +24 lines, -0 lines 0 comments ? errors Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Jakob
1 year, 6 months ago #1
Michael Starzinger
LGTM. https://codereview.chromium.org/11031002/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode9 ChangeLog:9: Fixed Clang warning about tautological compare (Chromium issue ...
1 year, 6 months ago #2
Jakob
1 year, 6 months ago #3
https://codereview.chromium.org/11031002/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode9
ChangeLog:9: Fixed Clang warning about tautological compare (Chromium issue
151927).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

Done.

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode11
ChangeLog:11: Avoid wrong imul deopt on ia32 and x64 (issue 2339).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

Done.

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode19
ChangeLog:19: atomically (issue 2346).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

IIUC this is a real (and potentially visible) bugfix, so let's keep it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6