Issue 11031002: Prepare push to trunk. Now working on version 3.14.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11031002: Prepare push to trunk. Now working on version 3.14.2. (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.14.2. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12641

Patch Set 2 : addressed comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/11031002/diff/1/ChangeLog File ChangeLog (right): https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode9 ChangeLog:9: Fixed Clang warning about tautological compare (Chromium issue ...

8 years, 2 months ago (2012-10-01 16:15:52 UTC) #2

Jakob Kummerow

8 years, 2 months ago (2012-10-01 16:19:24 UTC) #3

https://codereview.chromium.org/11031002/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode9
ChangeLog:9: Fixed Clang warning about tautological compare (Chromium issue
151927).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

Done.

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode11
ChangeLog:11: Avoid wrong imul deopt on ia32 and x64 (issue 2339).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

Done.

https://codereview.chromium.org/11031002/diff/1/ChangeLog#newcode19
ChangeLog:19: atomically (issue 2346).
On 2012/10/01 16:15:52, Michael Starzinger wrote:
> This is probably no interesting to embedders, let's drop it.

IIUC this is a real (and potentially visible) bugfix, so let's keep it.

Expand Messages | Collapse Messages

Issue 11031002: Prepare push to trunk. Now working on version 3.14.2. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages