Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103083002: Disable CredentialManagerClientTest on Android (Closed)

Created:
5 years, 8 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 8 months ago
Reviewers:
Cait (Slow), blundell
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable CredentialManagerClientTest on Android CredentialManagerClientTest has crashed on Android since commit d94a4430bc4448406b7564790d06110c7c5bcaaf was merged. BUG=481415 Committed: https://crrev.com/9313fe919a3ff8457bddb2fa1cb04784156a0823 Cr-Commit-Position: refs/heads/master@{#327137}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/content/renderer/credential_manager_client_browsertest.cc View 1 8 chunks +21 lines, -12 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
caitkp@ and blundell@, please review this CL.
5 years, 8 months ago (2015-04-27 00:29:23 UTC) #2
blundell
lgtm
5 years, 8 months ago (2015-04-27 10:39:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103083002/20001
5 years, 8 months ago (2015-04-27 21:19:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 21:37:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:38:25 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9313fe919a3ff8457bddb2fa1cb04784156a0823
Cr-Commit-Position: refs/heads/master@{#327137}

Powered by Google App Engine
This is Rietveld 408576698