trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc - Issue 110303003: Revert 240548 "Enable platform echo cancellation through the Aud..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc

Issue 110303003: Revert 240548 "Enable platform echo cancellation through the Aud..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/content/renderer/media/webrtc_audio_device_unittest.cc ('k') | trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc

===================================================================

--- trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc (revision 240588)

+++ trunk/src/content/renderer/media/webrtc_local_audio_track_unittest.cc (working copy)

@@ -168,8 +168,7 @@

.WillOnce(Return());

capturer_->SetCapturerSource(capturer_source_,

params_.channel_layout(),

- params_.sample_rate(),

- params_.effects());

+ params_.sample_rate());

}

media::AudioParameters params_;

@@ -461,8 +460,7 @@

EXPECT_CALL(*new_source.get(), OnStart());

capturer_->SetCapturerSource(new_source,

params_.channel_layout(),

- params_.sample_rate(),

- params_.effects());

+ params_.sample_rate());

// Stop the track.

EXPECT_CALL(*new_source.get(), OnStop());

@@ -506,8 +504,7 @@

EXPECT_CALL(*new_source.get(), OnInitialize(_, new_capturer.get(), 0));

new_capturer->SetCapturerSource(new_source,

media::CHANNEL_LAYOUT_MONO,

- 44100,

- media::AudioParameters::NO_EFFECTS);

+ 44100);

// Setup the second audio track, connect it to the new capturer and start it.

EXPECT_CALL(*new_source.get(), SetAutomaticGainControl(true));

@@ -563,12 +560,11 @@

scoped_refptr<MockCapturerSource> source(

new MockCapturerSource(capturer.get()));

capturer->Initialize(-1, params.channel_layout(), params.sample_rate(),

- params.frames_per_buffer(), 0, std::string(), 0, 0,

- params.effects());

+ params.frames_per_buffer(), 0, std::string(), 0, 0);

EXPECT_CALL(*source.get(), OnInitialize(_, capturer.get(), 0));

capturer->SetCapturerSource(source, params.channel_layout(),

- params.sample_rate(), params.effects());

+ params.sample_rate());

// Setup a audio track, connect it to the capturer and start it.

EXPECT_CALL(*source.get(), SetAutomaticGainControl(true));