Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11030044: Merge 159454 - Flush at the end of local file writing in FileWriter API. (Closed)

Created:
8 years, 2 months ago by kinaba
Modified:
8 years, 2 months ago
Reviewers:
kinaba
CC:
chromium-reviews, cbentzel+watch_chromium.org, rdsmith+dwatch_chromium.org, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Merge 159454 - Flush at the end of local file writing in FileWriter API. This CL ensures the written content is flushed physically before fileWriter.write() invokes the "onwriteend" event, for native local files. Remote files (Google Drive files in Chrome OS) nor FileSystem API files (in PERSISTENT or TEMPORARY storage) aren't affected. The summary of the changes: * Call Flush() before the final callback. (webkit/fileapi/file_writer_delegate.cc) * Delegate Flush() to net::FileStream::Flush (webkit/fileapi/local_file_stream_writer.cc) * No-op implementation for Flush(). (webkit/fileapi/sanbox_file_stream_writer.cc) (webkit/chromeos/fileapi/remote_file_stream_writer.cc) * Implementation of asynchronous Flush. (net/base/file_stream_{posix,win}.cc) * Other files are just for reflecting the rename Flush -> FlushSync. BUG=144790 R=willchan@chromium.org,kinuko@chromium.org,benjhayden@chromium.org TBR=marja@chromium.org TEST=out/Debug/browser_tests --gtest_filter='*FileSystemApi*' TEST=./webkit/tools/layout_tests/run_webkit_tests.sh fast/filesystem TEST=Manual steps reported in the issue. Review URL: https://codereview.chromium.org/10986045 TBR=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -17 lines) Patch
M chrome/browser/sessions/session_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream.h View 1 chunk +23 lines, -2 lines 0 comments Download
M net/base/file_stream.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/base/file_stream_posix.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/file_stream_posix.cc View 2 chunks +36 lines, -1 line 0 comments Download
M net/base/file_stream_win.h View 3 chunks +8 lines, -1 line 0 comments Download
M net/base/file_stream_win.cc View 3 chunks +48 lines, -1 line 0 comments Download
M net/base/mock_file_stream.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/base/mock_file_stream.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_stream_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_stream_writer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/fileapi/file_stream_writer.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/fileapi/file_writer_delegate.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/fileapi/file_writer_delegate.cc View 4 chunks +38 lines, -3 lines 0 comments Download
M webkit/fileapi/local_file_stream_writer.h View 2 chunks +6 lines, -1 line 0 comments Download
M webkit/fileapi/local_file_stream_writer.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M webkit/fileapi/sandbox_file_stream_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/sandbox_file_stream_writer.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinaba
8 years, 2 months ago (2012-10-05 01:49:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698