Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1103003002: Delete session cookies immediately after loading the cookie DB. (attempt #2) (Closed)

Created:
5 years, 8 months ago by erikchen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete session cookies immediately after loading the cookie DB. (attempt #2) The original CL had non-determinism in the unit test. > Delete session cookies immediately after loading the cookie DB. > > Previously, the session cookies were deleted after all cookies were loaded into > memory. This allows for a race condition where new session cookies are inserted > into the database while the cookies are being loaded into memory, which causes > the new session cookies to also be deleted. > > BUG= > > Committed: https://crrev.com/ca924dcfb4f3c6b89e0c40898e42aec349b6b843 > Cr-Commit-Position: refs/heads/master@{#326672} BUG= Committed: https://crrev.com/016a5fdb25122fdd84afa9e12678ae7d209e567d Cr-Commit-Position: refs/heads/master@{#327104}

Patch Set 1 : Copy of patchset #4 id:120001 of https://codereview.chromium.org/1097593002/ #

Patch Set 2 : Remove non-determinism from unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -3 lines) Patch
M content/browser/net/sqlite_persistent_cookie_store.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 1 2 chunks +87 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
erikwright: PTAL You can diff patch set 2 against patch set 1 to see the ...
5 years, 8 months ago (2015-04-25 01:06:13 UTC) #2
erikwright (departed)
LGTM
5 years, 8 months ago (2015-04-27 18:48:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103003002/20001
5 years, 8 months ago (2015-04-27 18:52:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 19:49:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:50:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/016a5fdb25122fdd84afa9e12678ae7d209e567d
Cr-Commit-Position: refs/heads/master@{#327104}

Powered by Google App Engine
This is Rietveld 408576698