chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc - Issue 11030017: Add context to gfx::Screen calls in support of simultaneous desktop+ash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

Issue 11030017: Add context to gfx::Screen calls in support of simultaneous desktop+ash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix some new gfx::Screen additions Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/display_settings_provider.cc ('K') | « chrome/browser/ui/panels/display_settings_provider.cc ('k') | chrome/browser/ui/panels/panel_mouse_watcher_timer.cc » ('j') | chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc b/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

index 3cf1377ba1180f744011cd78b73f4c298b25e546..7db8886d5c2396e6cf78da3c409a97b46b42f49d 100644

--- a/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

@@ -83,7 +83,8 @@ class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {

// The position returned by the notification balloon is based on Mac's

// vertically inverted orientation. We need to flip it so that it can

// be compared against the position returned by the panel.

- gfx::Size screen_size = gfx::Screen::GetPrimaryDisplay().size();

+ gfx::Size screen_size =

+ gfx::Screen::GetNativeScreen()->GetPrimaryDisplay().size();

return screen_size.height() - balloon->GetPosition().y();

#else

return balloon->GetPosition().y() + balloon->GetViewSize().height();