Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1102953002: BR styled clear is ignored while partially relayouting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutBlockFlowLine.cpp
diff --git a/Source/core/layout/LayoutBlockFlowLine.cpp b/Source/core/layout/LayoutBlockFlowLine.cpp
index c54361d8dcafb16f8b0377802827645f70be5b36..6011d18a6f7d6927fea45e27c15a110e7afaf2b4 100644
--- a/Source/core/layout/LayoutBlockFlowLine.cpp
+++ b/Source/core/layout/LayoutBlockFlowLine.cpp
@@ -796,7 +796,9 @@ void LayoutBlockFlow::layoutRunsAndFloatsInRange(LineLayoutState& layoutState,
bool paginated = view()->layoutState() && view()->layoutState()->isPaginated();
LineMidpointState& lineMidpointState = resolver.midpointState();
InlineIterator endOfLine = resolver.position();
- bool checkForEndLineMatch = layoutState.endLine();
+ const bool needsToCheckEndLine = containsFloats() && lastChild() && lastChild()->isBR() && lastChild()->style()->clear();
leviw_travelin_and_unemployed 2015/04/24 18:55:47 Driveby: This needs a better name. The addition of
changseok 2015/04/24 21:53:08 Yes it does as long as I know. If the br places in
+ bool checkForEndLineMatch = layoutState.endLine() && !needsToCheckEndLine;
+
LayoutTextInfo renderTextInfo;
VerticalPositionCache verticalPositionCache;

Powered by Google App Engine
This is Rietveld 408576698