LayoutTests/fast/block/float/br-with-clear-4.html - Issue 1102953002: BR styled clear is ignored while partially relayouting.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/float/br-with-clear-4.html

Issue 1102953002: BR styled clear is ignored while partially relayouting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Better approach. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/block/float/br-with-clear-3.html ('K') | « LayoutTests/fast/block/float/br-with-clear-3-expected.html ('k') | LayoutTests/fast/block/float/br-with-clear-4-expected.html » ('j') | Source/core/layout/LayoutBlockFlowLine.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .green {

	4 background: green;

	5 float: right;

	6 width: 50%;

	7 height: 100px;

	8 }

	9 .yellow {

	10 background: yellow;

	11 }

	12 </style>

	13 <p>Test passes if the height of yellow box is identical with that of green box.< /p>

	14 <div class='green'>Floating box</div>

	15 <p class='yellow'>

	16 <a href='#'>Anchor</a><br>

	17 Text line.

	18 <br style="clear:both"><span></span>
	leviw_travelin_and_unemployed 2015/05/11 00:25:29 I think it'd be nice if you combined these test ca I think it'd be nice if you combined these test cases into one that used check-layout.js instead of ref tests, but I won't block it on that. changseok 2015/05/11 15:56:46 I didn't know the check-layout.js. Let me try to u Show quoted text On 2015/05/11 00:25:29, leviw wrote: > I think it'd be nice if you combined these test cases into one that used > check-layout.js instead of ref tests, but I won't block it on that. I didn't know the check-layout.js. Let me try to use it next time. thanks ;)
	19 </p>

	20 <script>

	21 window.onload = function() {

	22 document.body.offsetTop;

	23 document.querySelector('a').style.fontSize = '1.5em';

	24 }

	25 </script>

OLD	NEW