LayoutTests/fast/block/float/br-with-clear-3.html - Issue 1102953002: BR styled clear is ignored while partially relayouting.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/float/br-with-clear-3.html

Issue 1102953002: BR styled clear is ignored while partially relayouting. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .green {

	4 background: green;

	5 float: right;

	6 width: 50%;

	7 height: 100px;

	8 }

	9 .yellow {

	10 background: yellow;

	11 }

	12 </style>

	13 <p>Test passes if the height of yellow box is identical with that of green box.< /p>

	14 <div class='green'>Floating box</div>

	15 <p class='yellow'>

	16 <a href='#'>Set focus here.</a><br>

	17 Text line.

	18 <br style="clear:both">

	19 </p>

	20 <script>

	21 window.onload = function() {

	22 var anchor = document.querySelector('a');
	mstensho (USE GERRIT) 2015/04/25 17:31:14 This test is flaky on my computer (without your fi This test is flaky on my computer (without your fix it fails most of the time, but not always). I don't know why a focus / blur requires a relayout anyway. Maybe you should make some explicit style modification on some node to trigger the buggy relayout instead? And put a "document.body.offsetTop;" in front of the style modification code, to make sure that you get separate layout passes? changseok 2015/04/26 01:09:01 Hrm. That's weird. I've never failed the test with Show quoted text On 2015/04/25 17:31:14, mstensho wrote: > This test is flaky on my computer (without your fix it fails most of the time, > but not always). I don't know why a focus / blur requires a relayout anyway. > Maybe you should make some explicit style modification on some node to trigger > the buggy relayout instead? And put a "document.body.offsetTop;" in front of the > style modification code, to make sure that you get separate layout passes? Hrm. That's weird. I've never failed the test with my fix. :/ Why focus/blur requires a relayout is that it causes drawing/removing a focus ring on anchor node. I don't know what is the problem on your system through, you might block to draw a focus ring? Well O.K. let me update the test as you said. It's just a piece of cake.
	23 anchor.focus();

	24 anchor.blur();

	25 }

	26 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/block/float/br-with-clear-3-expected.html » ('j') | Source/core/layout/LayoutBlockFlowLine.cpp » ('J')